Re: [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108

[Heiko Stuebner]

Hi Andy,

Am Montag, 31. Juli 2017, 18:19:19 CEST schrieb Andy Yan:
> Add saradc device tree node for rv1108
> 
> Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> ---
> 
>  arch/arm/boot/dts/rv1108.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
> index 1fc467e..958fecd 100644
> --- a/arch/arm/boot/dts/rv1108.dtsi
> +++ b/arch/arm/boot/dts/rv1108.dtsi
> @@ -275,6 +275,18 @@
>  		status = "disabled";
>  	};
>  
> +	adc: adc@1038c000 {
> +		compatible = "rockchip,rk3399-saradc";

you should amend the binding txt to make this something like
compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc"

See for example the bindings/mmc/rockchip-dw-mshc.txt as inspiration.

Heiko