Re: [PATCH 09/15] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE v6
From: Michal Hocko
Date: Tue Aug 01 2017 - 08:18:02 EST
On Mon 31-07-17 13:21:24, Jerome Glisse wrote:
> On Fri, Jul 28, 2017 at 01:10:03PM +0200, Michal Hocko wrote:
> > I haven't seen a newer version posted but the same comment applies on
> > your hmm-v25-4.9 git version from
> > git://people.freedesktop.org/~glisse/linux
> > On Wed 28-06-17 14:00:41, Jérôme Glisse wrote:
> > > This introduce a simple struct and associated helpers for device driver
> > > to use when hotpluging un-addressable device memory as ZONE_DEVICE. It
> > > will find a unuse physical address range and trigger memory hotplug for
> > > it which allocates and initialize struct page for the device memory.
> > Please document the hotplug semantic some more please (who is in charge,
> > what is the lifetime, userspace API to add/remove this memory if any
> > etc...).
> > I can see you call add_pages. Please document why arch_add_memory (like
> > devm_memremap_pages) is not used. You also never seem to online the
> > range which is in line with nvdim usage and it is OK. But then I fail to
> > understand why you need
> I added documentation in function and in commit message:
OK, that makes more clear. Thanks!