Re: [PATCH v4 05/15] selinux: Refactor to remove bprm_secureexec hook

[Andy Lutomirski]

On Mon, Jul 31, 2017 at 4:51 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> The SELinux bprm_secureexec hook can be merged with the bprm_set_creds
> hook since it's dealing with the same information, and all of the details
> are finalized during the first call to the bprm_set_creds hook via
> prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored
> via bprm->called_set_creds).
>
> Here, the test can just happen at the end of the bprm_set_creds hook,
> and the bprm_secureexec hook can be dropped.
>
> Cc: Stephen Smalley <sds@xxxxxxxxxxxxx>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Acked-by: Paul Moore <paul@xxxxxxxxxxxxxx>
> Tested-by: Paul Moore <paul@xxxxxxxxxxxxxx>
> Acked-by: Serge Hallyn <serge@xxxxxxxxxx>

Reviewed-by: Andy Lutomirski <luto@xxxxxxxxxx>