Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile to configure the kernel for this new module to configure the kernel for this new module.

From: Stephen Hemminger
Date: Tue Aug 01 2017 - 10:49:41 EST


On Tue, 1 Aug 2017 17:50:05 +0800
mohamedalrshah <mohamed.asnd@xxxxxxxxx> wrote:

> From: Mohamed Alrshah <mohamed.asnd@xxxxxxxxx>
>

Please add more background on Agile-SD in the email commit message.


> +static struct tcp_congestion_ops agilesdtcp __read_mostly = {
> + .init = agilesdtcp_init,
> + .ssthresh = agilesdtcp_recalc_ssthresh, //REQUIRED
> + .cong_avoid = agilesdtcp_cong_avoid, //REQUIRED
> + .set_state = agilesdtcp_state,
> + .undo_cwnd = agilesdtcp_undo_cwnd,
> + .pkts_acked = agilesdtcp_acked,
> + .owner = THIS_MODULE,
> + .name = "agilesd", //REQUIRED
> + //.min_cwnd = agilesdtcp_min_cwnd, //NOT REQUIRED
> +};

Your code must match kernel coding style. See Documentation for more
info and use the checkpatch.pl checking script.