Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers

From: David Miller
Date: Tue Aug 01 2017 - 18:29:54 EST


From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Sun, 30 Jul 2017 18:31:17 -0700

> In preparation for the randstruct gcc plugin performing randomization of
> structures that are entirely function pointers, use designated initializers
> so the compiler doesn't get angry.
>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> This is a prerequisite for the future randstruct fptr randomization. I'd
> prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from
> someone on net-dev, or if possible, have it applied to v4.13 via net-dev.

Please queue this up into the gcc-plugin tree then:

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

It isn't a bug fix so I would only have put it into 'net-next' rather
than 'net'.

Thanks.