Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h
From: Masahiro Yamada
Date: Tue Aug 01 2017 - 21:20:12 EST
2017-08-01 20:04 GMT+09:00 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>:
> On Tue, Aug 1, 2017 at 10:53 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> On Mon, Jul 31, 2017 at 4:04 PM, Andy Shevchenko
>> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>> On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote:
>>>> On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko
>>>> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>>> > If Linus is okay with the following proposal I would rather go with
>>>> > it,
>>>> > i.e. logical split the series to
>>>> > 1. Fix IRQ related headers inclusion
>>>> > 2. Fix pinconf-generic.h inclusion
>>>> > 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)
>>>> That works fine with me, but also one big patch actually, I do not
>>>> want to make it too much work to refactor obviously incorrect things.
>>>> As soon as we have rough consensus on this and the build robot
>>>> are happy I will apply it to GPIO and also pull it into the pinctrl
>>> For me priorities like this:
>>> 1) it works after the patch being applied (no regressions);
>>> 2) it makes code cleaner at the end;
>>> 3) it is presented in logically split parts.
>>> So, as long as 1) and 2) are satisfied I can neglect on 3).
>> We are in violent agreement :D
> What I would like to say is that is up to you after all :-)
> For me looks better to split.
I will split this into sensible chunks.
As I mentioned before, linux/gpio/driver.h is included from several sub-systems,
so I need at least two development cycles to finish this task.
 Send patches to subsystems (gpio, pinctrl, etc.) for v4.14
(splitting into sensible chunks, like per-driver)
 Drop unneeded includes from linux/gpio/driver.h for v4.15