QRE: [PATCH v2] qe: fix compile issue for arm64
From: Qiang Zhao
Date: Tue Aug 01 2017 - 21:58:20 EST
Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> -----Original Message-----
> From: Michael Ellerman [mailto:mpe@xxxxxxxxxxxxxx]
> Sent: Monday, July 31, 2017 6:37 PM
> To: Qiang Zhao <qiang.zhao@xxxxxxx>; oss@xxxxxxxxxxxx
> Cc: valentin.longchamp@xxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH v2] qe: fix compile issue for arm64
>
> Qiang Zhao <qiang.zhao@xxxxxxx> writes:
>
> > Fri 7/28/2017 2:14 PM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> >
> >> -----Original Message-----
> >> From: Michael Ellerman [mailto:mpe@xxxxxxxxxxxxxx]
> >> Sent: Friday, July 28, 2017 2:14 PM
> >> To: Qiang Zhao <qiang.zhao@xxxxxxx>; oss@xxxxxxxxxxxx
> >> Cc: valentin.longchamp@xxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> >> linux- kernel@xxxxxxxxxxxxxxx; Qiang Zhao <qiang.zhao@xxxxxxx>
> >> Subject: Re: [PATCH v2] qe: fix compile issue for arm64
> >>
> >> Zhao Qiang <qiang.zhao@xxxxxxx> writes:
> >>
> >> > Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxx>
> >> > ---
> >> > Changes for v2:
> >> > - include all Errata QE_General4 in #ifdef
> >> >
> >> > drivers/soc/fsl/qe/qe.c | 2 ++
> >> > 1 file changed, 2 insertions(+)
> >>
> >> AFAICS this driver can only be built on PPC, what am I missing?
> >>
> >> config QUICC_ENGINE
> >> bool "Freescale QUICC Engine (QE) Support"
> >> depends on FSL_SOC && PPC32
> >>
> >> cheers
> >
> > I sent another patchset to support it on arm64.
>
> Where? I don't see it.
>
> Shouldn't this patch be part of that series? Otherwise when that series is merged
> the build will break on arm64.
>
You are correct, thanks for your recommend.
I will add this patch to the patchset.
Thank you!
BR
Qiang Zhao