Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

From: Dan Carpenter
Date: Wed Aug 02 2017 - 04:19:43 EST



The subject is too long.

On Wed, Aug 02, 2017 at 01:01:55AM +0530, Rishabh Hardas wrote:
> This is a 5 patch series which solves coding style issues
> as marked by checkpatch.pl in the file pi433_if.h and
> contains changes that have to be made in other files as a
> consequence of the changes made in pi433_if.h

This looks like the description of 5 patches, but that should be in the
[PATCH 0/5] summary. What we want here is the description of this
patch.

This patch does too many things, deleting stuff, breaking up long lines,
changing comments and renaming enums. It should be 4 patches:
[patch 1] delete stuff
[patch 2] break long lines
...
etc.

regards,
dan carpenter