Re: [PATCH 1/2] Add sysfs based cpuinfo structure

[Greg KH]

On Wed, Aug 02, 2017 at 05:14:11PM +0200, Felix Schnizlein wrote:
> Create a new sysfs attribute group called 'info' for each
> online cpu. The cleaned up cpuinfo shows up in a sysfs
> subdirectory here: /sys/devices/system/cpu/cpu#/info.
> 
> Define preprocessor macros (CPUINFO_DEFINE_* and CPUINFO_ATTR) to make
> defining new sysfs attributes for cpuinfo more easy.
> 
> Add basic documentation for the info sysfs tree.
> 
> Signed-off-by: Felix Schnizlein <fschnizlein@xxxxxxxx>
> Signed-off-by: Thomas Renninger <trenn@xxxxxxxx>
> ---
>  Documentation/ABI/testing/sysfs-devices-system-cpu | 17 ++++++++
>  arch/Kconfig                                       |  3 ++
>  drivers/base/Makefile                              |  1 +
>  drivers/base/cpuinfo.c                             | 48 ++++++++++++++++++++++
>  include/linux/cpuhotplug.h                         |  1 +
>  include/linux/cpuinfo.h                            | 43 +++++++++++++++++++
>  6 files changed, 113 insertions(+)
>  create mode 100644 drivers/base/cpuinfo.c
>  create mode 100644 include/linux/cpuinfo.h
> 
> diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
> index f3d5817..fbaf165 100644
> --- a/Documentation/ABI/testing/sysfs-devices-system-cpu
> +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
> @@ -373,3 +373,20 @@ Contact:	Linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>
>  Description:	information about CPUs heterogeneity.
>  
>  		cpu_capacity: capacity of cpu#.
> +
> +What:		/sys/devices/system/cpu/cpu#/info/
> +Date:		June 2017
> +Contact:	Linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>
> +Description:	Various information about the online cpu. Which attributes are
> +		available depends on the architecture, kernel configuration and
> +                cpu model.

tabs?

> +
> +What:		/sys/devices/system/cpu/cpu#/info/
> +		/sys/devices/system/cpu/cpu#/info/vendor_id
> +		/sys/devices/system/cpu/cpu#/info/cpu_family
> +		/sys/devices/system/cpu/cpu#/info/model
> +		/sys/devices/system/cpu/cpu#/info/model_name
> +		/sys/devices/system/cpu/cpu#/info/stepping
> +		/sys/devices/system/cpu/cpu#/info/flags
> +		/sys/devices/system/cpu/cpu#/info/bugs
> +		/sys/devices/system/cpu/cpu#/info/bogomips

Can you guarantee that all arches will be able to provide these?

thanks,

greg k-h