Re: [Patch V3] crypto: x86/sha1 : Fix reads beyond the number of blocks passed

From: Jan Stancek
Date: Wed Aug 02 2017 - 15:18:59 EST





----- Original Message -----
> On Wed, 2017-08-02 at 10:13 -0700, Megha Dey wrote:
> > It was reported that the sha1 AVX2 function(sha1_transform_avx2) is
> > reading ahead beyond its intended data, and causing a crash if the next
> > block is beyond page boundary:
> > http://marc.info/?l=linux-crypto-vger&m=149373371023377
> >
> > This patch makes sure that there is no overflow for any buffer length.
> >
> > It passes the tests written by Jan Stancek that revealed this problem:
> > https://github.com/jstancek/sha1-avx2-crash
>
> Hi Jan,
>
> Is it ok to add your Tested-by?

Yes, v3 patch is exactly the diff I was testing.

Regards,
Jan