Re: [PATCH 2/2] qlcnic: add const to bin_attribute structure

[Patil, Harish]

-----Original Message-----
From: Bhumika Goyal <bhumirks@xxxxxxxxx>
Date: Wednesday, August 2, 2017 at 11:27 PM
To: "julia.lawall@xxxxxxx" <julia.lawall@xxxxxxx>, "kvalo@xxxxxxxxxxxxxx"
<kvalo@xxxxxxxxxxxxxx>, "linux-wireless@xxxxxxxxxxxxxxx"
<linux-wireless@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx"
<netdev@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx"
<linux-kernel@xxxxxxxxxxxxxxx>, Harish Patil <Harish.Patil@xxxxxxxxxx>,
"Chopra, Manish" <Manish.Chopra@xxxxxxxxxx>, Dept-GE Linux NIC Dev
<Dept-GELinuxNICDev@xxxxxxxxxx>
Cc: Bhumika Goyal <bhumirks@xxxxxxxxx>
Subject: [PATCH 2/2] qlcnic: add const to bin_attribute structure

>Add const to bin_attribute structure as it is only passed to the
>functions sysfs_{remove/create}_bin_file. The corresponding
>arguments are of type const, so declare the structure to be const.
>
>Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
>---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>index 73027a6..82fcb83 100644
>--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>@@ -1248,7 +1248,7 @@ static ssize_t
>qlcnic_83xx_sysfs_flash_write_handler(struct file *filp,
> 	.write = qlcnic_sysfs_write_pm_config,
> };
> 
>-static struct bin_attribute bin_attr_flash = {
>+static const struct bin_attribute bin_attr_flash = {
> 	.attr = {.name = "flash", .mode = (S_IRUGO | S_IWUSR)},
> 	.size = 0,
> 	.read = qlcnic_83xx_sysfs_flash_read_handler,
>-- 
>1.9.1
>
>Acked-by: Harish Patil <harish.patil@xxxxxxxxxx>