Re: [PATCH] watchdog: moxart_wdt: Replace decimal permissions with 4 digit octal

[Guenter Roeck]

On 07/29/2017 02:15 AM, SZ Lin wrote:
> ERROR: Use 4 digit octal (0777) not decimal permissions
>
> This error was detected by checkpatch.pl
>
> Signed-off-by: SZ Lin <sz.lin@xxxxxxxx>

I think checkpatch is overdoing it a bit here. There are more than 2,000 of those.
Plus, I really don't see the value in this change.

Guenter

> ---
>   drivers/watchdog/moxart_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c
> index 2c4a73d1e214..05684aa89b88 100644
> --- a/drivers/watchdog/moxart_wdt.c
> +++ b/drivers/watchdog/moxart_wdt.c
> @@ -170,7 +170,7 @@ static struct platform_driver moxart_wdt_driver = {
>   };
>   module_platform_driver(moxart_wdt_driver);
>   
> -module_param(heartbeat, int, 0);
> +module_param(heartbeat, int, 0000);
>   MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds");
>   
>   MODULE_DESCRIPTION("MOXART watchdog driver");