Re: [PATCH] crypto: atmel-tdes: remove unnecessary static in atmel_tdes_remove()

From: Herbert Xu
Date: Thu Aug 03 2017 - 02:11:50 EST


Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote:
> Remove unnecessary static on local variable tdes_dd. Such variable
> is initialized before being used, on every execution path throughout
> the function. The static has no benefit and, removing it reduces the
> object file size.
>
> This issue was detected using Coccinelle and the following semantic patch:
> https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci
>
> In the following log you can see a significant difference in the object
> file size. This log is the output of the size command, before and after
> the code change:
>
> before:
> text data bss dec hex filename
> 17079 8704 128 25911 6537 drivers/crypto/atmel-tdes.o
>
> after:
> text data bss dec hex filename
> 17039 8616 64 25719 6477 drivers/crypto/atmel-tdes.o
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt