RE: [PATCH] drivers: jtag: fix resource_size.cocci warnings

From: Oleksandr Shamray
Date: Thu Aug 03 2017 - 10:48:44 EST


> -----Original Message-----
> From: kbuild test robot [mailto:lkp@xxxxxxxxx]
> Sent: Thursday, August 3, 2017 5:36 PM
> To: Oleksandr Shamray <oleksandrs@xxxxxxxxxxxx>
> Cc: kbuild-all@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; arnd@xxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; openbmc@xxxxxxxxxxxxxxxx; joel@xxxxxxxxx;
> jiri@xxxxxxxxxxx; tklauser@xxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx;
> mec@xxxxxxxxx; vadimp@xxxxxxxxxxxxx; system-sw-low-level <system-sw-
> low-level@xxxxxxxxxxxx>; Oleksandr Shamray <oleksandrs@xxxxxxxxxxxx>;
> Jiri Pirko <jiri@xxxxxxxxxxxx>
> Subject: [PATCH] drivers: jtag: fix resource_size.cocci warnings
>
> drivers/jtag/jtag-aspeed.c:724:37-40: ERROR: Missing resource_size with res
>
>
> Use resource_size function on resource object instead of explicit computation.
>
> Generated by: scripts/coccinelle/api/resource_size.cocci
>
> Fixes: acf0c42bb646 ("drivers: jtag: Add Aspeed SoC 24xx and 25xx families
> JTAG master driver")
> CC: Oleksandr Shamray <oleksandrs@xxxxxxxxxxxx>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Acked-by: Oleksandr Shamray <oleksandrs@xxxxxxxxxxxx>

> ---
>
> jtag-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/jtag/jtag-aspeed.c
> +++ b/drivers/jtag/jtag-aspeed.c
> @@ -721,7 +721,7 @@ int aspeed_jtag_init(struct platform_dev
> return 0;
>
> out_region:
> - release_mem_region(res->start, res->end - res->start + 1);
> + release_mem_region(res->start, resource_size(res));
> return err;
> }
>