Re: [PATCH 2/2] char: xilinx_hwicap: Fix warnings in the driver

[Rob Herring]

On Fri, Jul 28, 2017 at 03:17:26PM +0200, Michal Simek wrote:
> From: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> 
> This patch fixes the below warning
>         --> Use #include <linux/io.h> instead of <asm/io.h>
>         --> Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
>         --> please, no space before tabs
>         --> Block comments use a trailing */ on a separate line
>         --> Possible unnecessary 'out of memory' message
>         --> Block comments use * on subsequent lines
>         --> Block comments use a trailing */ on a separate line
>         --> braces {} are not necessary for any arm of this statement
>         --> DT compatible string "xlnx,opb-hwicap-1.00.b"
> 	    appears un-documented
>         --> DT compatible string "xlnx,xps-hwicap-1.00.a"
>             appears un-documented
> 
> Signed-off-by: Nava kishore Manne <navam@xxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
> 
>  Documentation/devicetree/bindings/xilinx.txt |  2 ++

It's preferred to split bindings to separate patches. No need unless you 
respin:

Acked-by: Rob Herring <robh@xxxxxxxxxx>

>  drivers/char/xilinx_hwicap/xilinx_hwicap.c   | 35 ++++++++++++++--------------
>  drivers/char/xilinx_hwicap/xilinx_hwicap.h   |  6 +++--
>  3 files changed, 23 insertions(+), 20 deletions(-)