Re: [PATCH V3 net-next 02/21] net-next/hinic: Initialize hw device components

[David Miller]

From: Aviad Krawczyk <aviad.krawczyk@xxxxxxxxxx>
Date: Thu, 3 Aug 2017 17:54:08 +0800

> +static int get_capability(struct hinic_hwdev *hwdev,
> +			  struct hinic_dev_cap *dev_cap)
> +{
> +	struct hinic_hwif *hwif = hwdev->hwif;
> +	struct hinic_cap *nic_cap = &hwdev->nic_cap;
> +	int num_aeqs, num_ceqs, num_irqs, num_qps;

Please order local variable declarations from longest to shortest
line (aka: reverse christmas tree order).

Move the initialization down into the code if that is necessary
to achiever this.

> +static int get_dev_cap(struct hinic_hwdev *hwdev)
> +{
> +	struct hinic_pfhwdev *pfhwdev;
> +	struct hinic_hwif *hwif = hwdev->hwif;
> +	struct pci_dev *pdev = hwif->pdev;
> +	int err;

Likewise.