Re: [PATCH] PCI: Add const to bin_attribute structures
From: Bjorn Helgaas
Date: Thu Aug 03 2017 - 19:23:37 EST
On Wed, Aug 02, 2017 at 08:57:27PM +0530, Bhumika Goyal wrote:
> Add const to bin_attribute structures as they are only passed to the
> functions sysfs_{remove/create}_bin_file. The corresponding arguments
> are of type const, so declare the structures to be const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
Applied to pci/misc for v4.14, thanks!
> ---
> drivers/pci/pci-sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 2f3780b..2fc358c 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1431,7 +1431,7 @@ static ssize_t pci_read_rom(struct file *filp, struct kobject *kobj,
> return count;
> }
>
> -static struct bin_attribute pci_config_attr = {
> +static const struct bin_attribute pci_config_attr = {
> .attr = {
> .name = "config",
> .mode = S_IRUGO | S_IWUSR,
> @@ -1441,7 +1441,7 @@ static ssize_t pci_read_rom(struct file *filp, struct kobject *kobj,
> .write = pci_write_config,
> };
>
> -static struct bin_attribute pcie_config_attr = {
> +static const struct bin_attribute pcie_config_attr = {
> .attr = {
> .name = "config",
> .mode = S_IRUGO | S_IWUSR,
> --
> 1.9.1
>