Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.

From: Boris Brezillon
Date: Fri Aug 04 2017 - 06:08:21 EST


On Wed, 2 Aug 2017 13:32:42 -0700
Eric Anholt <eric@xxxxxxxxxx> wrote:

> drm_bridge_remove() is for unregistering a bridge driver, not for

s/driver/device/

> detaching a bridge from its consumer.
>
> Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.")
> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/vc4/vc4_dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 13481bb6322f..d1e0dc908048 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>
> pm_runtime_disable(dev);
>
> - drm_bridge_remove(dsi->bridge);
> vc4_dsi_encoder_destroy(dsi->encoder);
>
> mipi_dsi_host_unregister(&dsi->dsi_host);