Re: [PATCH] intel-vbtn: match power button on press rather than release

From: Darren Hart
Date: Fri Aug 04 2017 - 13:31:02 EST


On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
> This fixes a problem where the system gets stuck in a loop
> unable to wakeup via power button in s2idle.
>
> The problem happens because:
> - press power button:
> - system emits 0xc0 (power press), event ignored
> - system emits 0xc1 (power release), event processed,
> emited as KEY_POWER
> - set wakeup_mode to true
> - system goes to s2idle
> - press power button
> - system emits 0xc0 (power press), wakeup_mode is true,
> system wakes
> - system emits 0xc1 (power release), event processed,
> emited as KEY_POWER
> - system goes to s2idle again
>
> To avoid this situation, process the presses (which matches what
> intel-hid does too).
>
> Verified on an Dell XPS 9365
>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>

This looks good to me - responding to the release is non-intuitive IMHO
anyway. I'd like to see agreement from AceLan, but this should go into
the 4.13 rc cycle (at rc3 currently).

--
Darren Hart
VMware Open Source Technology Center