Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code

From: Vivien Didelot
Date: Sat Aug 05 2017 - 16:12:41 EST


Hi Andrew,

Andrew Lunn <andrew@xxxxxxx> writes:

>> @@ -251,8 +251,9 @@ dsa_switch_setup(struct dsa_switch_tree *dst, struct net_device *master,
>> ds->cd = cd;
>> ds->ops = ops;
>> ds->priv = priv;
>> + ds->dev = parent;
>
> Is this even needed? dsa_switch_alloc() does ds->dev = dev.

You are correct! Respinning.


Thanks,

Vivien