Re: [PATCH] cpufreq: Simplify cpufreq_can_do_remote_dvfs()
From: Viresh Kumar
Date: Sun Aug 06 2017 - 23:34:06 EST
On 04-08-17, 14:57, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The if () in cpufreq_can_do_remote_dvfs() is superfluous, so drop
> it and simply return the value of the expression under it.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
>
> On top of the current linux-next.
>
> ---
> include/linux/cpufreq.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> Index: linux-pm/include/linux/cpufreq.h
> ===================================================================
> --- linux-pm.orig/include/linux/cpufreq.h
> +++ linux-pm/include/linux/cpufreq.h
> @@ -578,11 +578,8 @@ static inline bool cpufreq_can_do_remote
> * - dvfs_possible_from_any_cpu flag is set
> * - the local and remote CPUs share cpufreq policy
> */
> - if (policy->dvfs_possible_from_any_cpu ||
> - cpumask_test_cpu(smp_processor_id(), policy->cpus))
> - return true;
> -
> - return false;
> + return policy->dvfs_possible_from_any_cpu ||
> + cpumask_test_cpu(smp_processor_id(), policy->cpus);
> }
>
> /*********************************************************************
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
viresh