Re: [PATCH v8 1/3] perf: cavium: Support memory controller PMU counters

From: Suzuki K Poulose
Date: Mon Aug 07 2017 - 05:37:25 EST

On 27/07/17 10:08, Jan Glauber wrote:
On Thu, Jul 27, 2017 at 07:11:57AM +0200, Borislav Petkov wrote:
On Wed, Jul 26, 2017 at 02:02:42PM -0700, David Daney wrote:
Also, if a given configuration disables CONFIG_EDAC there is some hackery
needed to get the perf portion of the driver included.

Yes, and we don't do performance counters in EDAC.

So you could add a small memory controller driver which does the
arbitration or fix the firmware.

OK. As fixing the firmware will take quite some time I'll go for the memory
controller driver that starts EDAC / PMU depending on their CONFIG_.

Please could you also rename CAVIUM_PMU to something like CAVIUM_MMC_PMU or even
CAVIUM_UNCOR_PMU ? The symbol could easily be mistaken for a "cavium" CPU PMU.


What would be the proper location for the multiplexer?
drivers/soc/cavium or drivers/misc?