Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing

From: Arnd Bergmann
Date: Mon Aug 07 2017 - 07:58:36 EST


On Mon, Aug 7, 2017 at 1:48 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Mon, Aug 07, 2017 at 01:36:09PM +0200, Arnd Bergmann wrote:
>> On Mon, Aug 7, 2017 at 1:20 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
>> > On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote:
>> >> When the audio driver selects CONFIG_PXA_SSP to be a loadable
>> >> module on a platform other than PXA, and the PXA SPI driver
>> >> is built-in, we get a link error in the SPI driver:
>
>> > Why doesn't this cause problems on PXA?
>
>> On PXA, we 'make' descends into arch/arm/plat-pxa/, where ssp.o
>> is located. On other ARM platforms (I guess except for MMP),
>> PLAT_PXA is not set, and on non-ARM architectures, we can't
>> get there anyway.
>
> Still missing a few steps of reasoning here...

Sorry, I just realized that you were trying to point out the incomplete
changelog. I must have accidentally closed the editor while working on
it, and then sent it out today after getting no regressions.

I'll resend with a proper changelog.

Arnd