Re: [PATCH 2/2] gpio: 74x164: handling enable-gpios

[Fabio Estevam]

On Mon, Aug 7, 2017 at 9:27 AM, Peng Fan <peng.fan@xxxxxxx> wrote:

> +       chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW);
> +       if (IS_ERR(chip->enable_gpio)) {
> +               dev_dbg(&spi->dev, "No enable-gpios property\n");
> +               chip->enable_gpio = NULL;

Also, the error handling here is not correct as it will never
propagate EPROBE_DEFER.

I will submit my version of the patch if you don't mind.