Re: [PATCH] ata: make ata_port_operations const

From: Joe Perches
Date: Mon Aug 07 2017 - 12:34:23 EST

On Mon, 2017-08-07 at 09:29 -0700, Tejun Heo wrote:
> Hello,
> On Mon, Aug 07, 2017 at 08:54:21PM +0530, Bhumika Goyal wrote:
> > I compiled the .o files and checked the size before and after
> > compilation. After making the structure const, bytes should move from
> > data to text segment of the memory and this is what happened. So, this
> > is how I tested it.
> Ah, I see, so the port_operations is never used directly. I'm not
> sure whether it'd be a good idea to selectively pick these and makr
> them const. Let's just leave them be.


Things that are never accessed as other than const should
be const no?

Why leave unnecessary exposure for muckery?