RE: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC

[Qiang Zhao]

On Mon 8/7/2017 3:02 PM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:

> -----Original Message-----
> From: Michael Ellerman [mailto:mpe@xxxxxxxxxxxxxx]
> Sent: Monday, August 07, 2017 3:02 PM
> To: Qiang Zhao <qiang.zhao@xxxxxxx>; tglx@xxxxxxxxxxxxx
> Cc: oss@xxxxxxxxxxxx; Qiang Zhao <qiang.zhao@xxxxxxx>; linuxppc-
> dev@xxxxxxxxxxxxxxxx; Xiaobo Xie <xiaobo.xie@xxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
> 
> Zhao Qiang <qiang.zhao@xxxxxxx> writes:
> 
> > QEIC was supported on PowerPC, and dependent on PPC, Now it is
> > supported on other platforms, so remove PPCisms.
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxx>
> > ---
> >  arch/powerpc/platforms/83xx/km83xx.c          |   1 -
> >  arch/powerpc/platforms/83xx/misc.c            |   1 -
> >  arch/powerpc/platforms/83xx/mpc832x_mds.c     |   1 -
> >  arch/powerpc/platforms/83xx/mpc832x_rdb.c     |   1 -
> >  arch/powerpc/platforms/83xx/mpc836x_mds.c     |   1 -
> >  arch/powerpc/platforms/83xx/mpc836x_rdk.c     |   1 -
> >  arch/powerpc/platforms/85xx/corenet_generic.c |   1 -
> >  arch/powerpc/platforms/85xx/mpc85xx_mds.c     |   1 -
> >  arch/powerpc/platforms/85xx/mpc85xx_rdb.c     |   1 -
> >  arch/powerpc/platforms/85xx/twr_p102x.c       |   1 -
> >  drivers/irqchip/irq-qeic.c                    | 188 +++++++++++---------------
> >  include/soc/fsl/qe/qe_ic.h                    | 132 ------------------
> >  12 files changed, 80 insertions(+), 250 deletions(-)  delete mode
> > 100644 include/soc/fsl/qe/qe_ic.h
> >
> > diff --git a/arch/powerpc/platforms/83xx/km83xx.c
> > b/arch/powerpc/platforms/83xx/km83xx.c
> > index d8642a4..b1cef0a 100644
> > --- a/arch/powerpc/platforms/83xx/km83xx.c
> > +++ b/arch/powerpc/platforms/83xx/km83xx.c
> > @@ -38,7 +38,6 @@
> >  #include <sysdev/fsl_soc.h>
> >  #include <sysdev/fsl_pci.h>
> >  #include <soc/fsl/qe/qe.h>
> > -#include <soc/fsl/qe/qe_ic.h>
> 
> You deleted that file in patch 2. So didn't you just break the build for the last two
> commits?

Sorry, I am not sure what you said. Could you explain?
Thank you!

BR
Qiang Zhao