Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()
From: SF Markus Elfring
Date: Tue Aug 08 2017 - 04:29:54 EST
>> https://patchwork.ozlabs.org/patch/798575/
>
> I submitted your patch
Thanks for your constructive feedback.
https://patchwork.ozlabs.org/patch/798850/
> and a fix to ps3vram_probe() with the other patches in my queue.
I find it nice that you picked this change opportunity up after
a bit of discussion (before an other developer would eventually
have tackled it also).
âCheck return of ps3vram_cache_initâ
https://patchwork.ozlabs.org/patch/798853/
1. Unfortunately, I find that this specific update suggestion does not fit
to the Linux coding style convention.
ââ
Do not unnecessarily use braces where a single statement will do.
ââ
2. How do you think about to use the check âif (error)â instead?
3. Will an additional commit description be useful?
Regards,
Markus