Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies
From: Zhang Rui
Date: Tue Aug 08 2017 - 05:15:18 EST
On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote:
> On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote:
> >
> > We get a Kconfig warning when selecting this without also enabling
> > CONFIG_PCI:
> >
> > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE &&
> > SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects
> > IOSF_MBI which has unmet direct dependencies (PCI)
> >
> > This adds a new depedency.
> >
> > Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common
> > APIs")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx
Applied.
thanks,
rui
> >
>
> >
> > ---
> > Âdrivers/thermal/Kconfig | 4 ++--
> > Â1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index b5b5facb8747..ac2a53823576 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
> > Â
> > Âconfig INTEL_SOC_DTS_IOSF_CORE
> > Â tristate
> > - depends on X86
> > + depends on X86 && PCI
> > Â select IOSF_MBI
> > Â help
> > Â ÂÂThis is becoming a common feature for Intel SoCs to
> > expose
> > the additional
> > @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
> > Â
> > Âconfig INTEL_SOC_DTS_THERMAL
> > Â tristate "Intel SoCs DTS thermal driver"
> > - depends on X86
> > + depends on X86 && PCI
> > Â select INTEL_SOC_DTS_IOSF_CORE
> > Â select THERMAL_WRITABLE_TRIPS
> > Â help