Re: [PATCH 7/9 v2] thermal: bcm2835: constify thermal_zone_of_device_ops structures

From: Stefan Wahren
Date: Tue Aug 08 2017 - 15:59:15 EST



> Julia Lawall <Julia.Lawall@xxxxxxx> hat am 8. August 2017 um 17:09 geschrieben:
>
>
> The thermal_zone_of_device_ops structure is only passed as the fourth
> argument to thermal_zone_of_sensor_register, which is declared as const.
> Thus the thermal_zone_of_device_ops structure itself can be const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

Still

Acked-by: Stefan Wahren <stefan.wahren@xxxxxxxx>

>
> ---
>
> v2: This patch was present in the original series
>
> drivers/thermal/broadcom/bcm2835_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
> index e6863c8..a4d6a0e 100644
> --- a/drivers/thermal/broadcom/bcm2835_thermal.c
> +++ b/drivers/thermal/broadcom/bcm2835_thermal.c
> @@ -145,7 +145,7 @@ static void bcm2835_thermal_debugfs(struct platform_device *pdev)
> debugfs_create_regset32("regset", 0444, data->debugfsdir, regset);
> }
>
> -static struct thermal_zone_of_device_ops bcm2835_thermal_ops = {
> +static const struct thermal_zone_of_device_ops bcm2835_thermal_ops = {
> .get_temp = bcm2835_thermal_get_temp,
> };
>
>