Re: [PATCH v06 13/36] x86 uapi asm/sembuf.h: include linux/types.h and linux/ipc.h

[Dmitry V. Levin]

On Sun, Aug 06, 2017 at 06:44:04PM +0200, Mikko Rapeli wrote:
> Fixes userspace compile errors like:
> 
> error: field âsem_permâ has incomplete type
>   struct ipc64_perm sem_perm; /* permissions .. see ipc.h */
> error: unknown type name â__kernel_time_tâ
>   __kernel_time_t sem_otime; /* last semop time */
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> ---
>  arch/x86/include/uapi/asm/sembuf.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/include/uapi/asm/sembuf.h b/arch/x86/include/uapi/asm/sembuf.h
> index cc2d6a3aeae7..f11ed5282eec 100644
> --- a/arch/x86/include/uapi/asm/sembuf.h
> +++ b/arch/x86/include/uapi/asm/sembuf.h
> @@ -1,6 +1,9 @@
>  #ifndef _ASM_X86_SEMBUF_H
>  #define _ASM_X86_SEMBUF_H
>  
> +#include <linux/types.h>
> +#include <linux/ipc.h>

I'd recommend to include <asm/ipcbuf.h> instead like I did some time ago,
see http://lkml.kernel.org/r/20170302002228.GB27132@xxxxxxxxxxxx


-- 
ldv

Attachment: signature.asc
Description: PGP signature