Re: [PATCH RFC v2 3/5] samples/bpf: Fix inline asm issues building samples on arm64

From: David Miller
Date: Tue Aug 08 2017 - 23:35:48 EST


From: Joel Fernandes <joelaf@xxxxxxxxxx>
Date: Mon, 7 Aug 2017 18:20:49 -0700

> On Mon, Aug 7, 2017 at 11:28 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>> The amount of hellish hacks we are adding to deal with this is getting
>> way out of control.
>
> I agree with you that hellish hacks are being added which is why it
> keeps breaking. I think one of the things my series does is to add
> back inclusion of asm headers that were previously removed (that is
> the worst hellish hack in my opinion that existing in mainline). So in
> that respect my patch is an improvement and makes it possible to build
> for arm64 platforms (which is currently broken in mainline).

Yeah that is a problem.

Perhaps another avenue of attack is to separate "type" header files from
stuff that has functiond declarations and inline assembler code.