Re: [v3, 1/2] hwmon: (it87) Split out chip registers setting code on probe path

[Maciej S. Szmigiero]

On 09.08.2017 06:27, Guenter Roeck wrote:
> On Wed, Aug 02, 2017 at 01:06:23AM +0200, Maciej S. Szmigiero wrote:
> > This commit splits out chip registers setting code on probe path to
> > separate functions so they can be reused for setting the device properly
> > again when system resumes from suspend.
> >
> > While we are at it let's also make clear that on IT8720 and IT8782 it's
> > the VCCH5V line that is (possibly) routed to in7.
> > This will make it consistent with a similar message that it printed on
> > IT8783.
> >
> > Signed-off-by: Maciej S. Szmigiero <mail@xxxxxxxxxxxxxxxxxxxxx>
>
> I finally got to this and tried to apply it, but it fails spectacularly.
> Even patch fails to apply each and every chunk. No idea what is going on.
> How did you generate the patch, and what was your baseline ?

It was generated from
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
(hwmon branch), but it looks like my MUA mangled it.

Will try to send again in a moment.
 
> Guenter

Maciej

> > ---
> > Changes from v1: Move code of common probe / resume steps to new functions
> > so we don't need to make large parts of probe function conditional on a
> > newly added 'resume' parameter.
> >
> > Changes from v2: Code move of common probe / resume steps to new functions
> > and actual resume functionality split into two, separate patches.
> >
> > Made a message about VCCH5V being routed to in7 consistent across all
> > chips.
> >
> >    drivers/hwmon/it87.c | 138 ++++++++++++++++++++++++++++++++-------------------
> >    1 file changed, 88 insertions(+), 50 deletions(-)
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html