Re: [PATCH v8 09/14] lockdep: Apply crossrelease to completions

[Peter Zijlstra]

On Mon, Aug 07, 2017 at 04:12:56PM +0900, Byungchul Park wrote:
> +static inline void wait_for_completion(struct completion *x)
> +{
> +	complete_acquire(x);
> +	__wait_for_completion(x);
> +	complete_release(x);
> +}
> +
> +static inline void wait_for_completion_io(struct completion *x)
> +{
> +	complete_acquire(x);
> +	__wait_for_completion_io(x);
> +	complete_release(x);
> +}
> +
> +static inline int wait_for_completion_interruptible(struct completion *x)
> +{
> +	int ret;
> +	complete_acquire(x);
> +	ret = __wait_for_completion_interruptible(x);
> +	complete_release(x);
> +	return ret;
> +}
> +
> +static inline int wait_for_completion_killable(struct completion *x)
> +{
> +	int ret;
> +	complete_acquire(x);
> +	ret = __wait_for_completion_killable(x);
> +	complete_release(x);
> +	return ret;
> +}

I don't understand, why not change __wait_for_common() ?