Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

From: Moni Shoua
Date: Wed Aug 09 2017 - 09:48:15 EST

Next message: Andrew Lunn: "Re: [PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops"
Previous message: Andrew Lunn: "Re: [PATCH 1/4] net-next: dsa: move struct dsa_device_ops to the global header file"
In reply to: Jason Gunthorpe: "Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h"
Next in thread: Jason Gunthorpe: "Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>
> I'm not sure this is a good idea, linux/in.h should not be included in
> userspace users of this file, 'sockaddr_in' needs to come from glibc's
> 'netinet/in.h' instead..
>
> Jason
Is it wrong to include include/uapi/linux/in.h from userspace?

Next message: Andrew Lunn: "Re: [PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops"
Previous message: Andrew Lunn: "Re: [PATCH 1/4] net-next: dsa: move struct dsa_device_ops to the global header file"
In reply to: Jason Gunthorpe: "Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h"
Next in thread: Jason Gunthorpe: "Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]