Re: [PATCH] kmod: test_kmod: Correctly lock reg_dev_mutex

From: Luis R. Rodriguez
Date: Wed Aug 09 2017 - 15:37:00 EST


On Tue, Aug 08, 2017 at 04:27:33PM -0700, Daniel Mentz wrote:
> It appears that, in the preamble of register_test_dev_kmod(),
> mutex_lock() has been confused with mutex_unlock().
>
> Previously, register_test_dev_kmod() never called mutex_lock() but
> instead, it called mutex_unlock() twice.
>
> Signed-off-by: Daniel Mentz <danielmentz@xxxxxxxxxx>
> Cc: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---

Thanks Daniel but someone beat you to the fix, I've sent this to Andrew
and he's integrated into his -mm tree. See:

http://lkml.kernel.org/r/20170802211450.27928-5-mcgrof@xxxxxxxxxx

This series had other fixes:

https://marc.info/?l=linux-kernel&m=150170850624962&w=2

I'll CC you on other kmod / test_kmod changes.

Luis