Re: [RFC v1 4/4] ipmi_bmc: bt-aspeed: port driver to IPMI BMC framework
From: Brendan Higgins
Date: Thu Aug 10 2017 - 01:30:01 EST
On Wed, Aug 9, 2017 at 7:31 PM, Jeremy Kerr <jk@xxxxxxxxxx> wrote:
> Hi Brendan,
>
>> The driver was handling interaction with userspace on its own. This
>> patch changes it to use the functionality of the ipmi_bmc framework
>> instead.
>>
>> Note that this removes the ability for the BMC to set SMS_ATN by making
>> an ioctl. If this functionality is required, it can be added back in
>> with a later patch.
>
> As Chris has mentioned, we do use this actively at the moment, so I'd
> prefer if we could not drop the support for SMS_ATN. However, using a
> different interface should be fine, if that helps.
Whoops, I did not realize that anyone was using it. Yeah, adding it back in
should not be too hard.
>
> Cheers,
>
>
> Jeremy