Re: [PATCH] mm: add pmd_t initializer __pmd() to work around a GCC bug.

[Zi Yan]

Ping. Just wonder what is the status of this patch.

This patch is trivial and I successfully compiled it for sparc32.
swp_entry_to_pmd() will be the only user of __pmd() in sparc32,
returning __pmd(0). Having __pmd() can help replace following
code in include/linux/swapops.h (in linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/swapops.h#n224):

static inline pmd_t swp_entry_to_pmd(swp_entry_t entry)
{
	pmd_t e;
	memset(&e, 0, sizeof(pmd_t));
	return e;
}

with:

static inline pmd_t swp_entry_to_pmd(swp_entry_t entry)
{
	return __pmd(0);
}

It makes the code more portable.

Thanks.

--
Best Regards
Yan Zi

On 3 Aug 2017, at 9:17, Zi Yan wrote:

> From: Zi Yan <zi.yan@xxxxxxxxxxxxxx>
>
> THP migration is added but only supports x86_64 at the moment. For all
> other architectures, swp_entry_to_pmd() only returns a zero pmd_t.
>
> Due to a GCC zero initializer bug #53119, the standard (pmd_t){0}
> initializer is not accepted by all GCC versions. __pmd() is a feasible
> workaround. In addition, sparc32's pmd_t is an array instead of a single
> value, so we need (pmd_t){ {0}, } instead of (pmd_t){0}. Thus,
> a different __pmd() definition is needed in sparc32.
>
> Signed-off-by: Zi Yan <zi.yan@xxxxxxxxxxxxxx>
> ---
>  arch/sparc/include/asm/page_32.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/sparc/include/asm/page_32.h b/arch/sparc/include/asm/page_32.h
> index 0efd0583a8c9..6249214148c2 100644
> --- a/arch/sparc/include/asm/page_32.h
> +++ b/arch/sparc/include/asm/page_32.h
> @@ -68,6 +68,7 @@ typedef struct { unsigned long iopgprot; } iopgprot_t;
>  #define iopgprot_val(x)	((x).iopgprot)
>
>  #define __pte(x)	((pte_t) { (x) } )
> +#define __pmd(x)	((pmd_t) { { (x) }, })
>  #define __iopte(x)	((iopte_t) { (x) } )
>  #define __pgd(x)	((pgd_t) { (x) } )
>  #define __ctxd(x)	((ctxd_t) { (x) } )
> @@ -95,6 +96,7 @@ typedef unsigned long iopgprot_t;
>  #define iopgprot_val(x)	(x)
>
>  #define __pte(x)	(x)
> +#define __pmd(x)	((pmd_t) { { (x) }, })
>  #define __iopte(x)	(x)
>  #define __pgd(x)	(x)
>  #define __ctxd(x)	(x)
> -- 
> 2.13.2

Attachment: signature.asc
Description: OpenPGP digital signature