Re: [PATCH v5 03/10] swiotlb: Map the buffer if it was unmapped by XPFO
From: Tycho Andersen
Date: Thu Aug 10 2017 - 12:23:06 EST
On Thu, Aug 10, 2017 at 09:01:06AM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Aug 09, 2017 at 02:07:48PM -0600, Tycho Andersen wrote:
> > +inline bool xpfo_page_is_unmapped(struct page *page)
> > +{
> > + if (!static_branch_unlikely(&xpfo_inited))
> > + return false;
> > +
> > + return test_bit(XPFO_PAGE_UNMAPPED, &lookup_xpfo(page)->flags);
> > +}
> > +EXPORT_SYMBOL(xpfo_page_is_unmapped);
>
> How can it be inline and 'EXPORT_SYMBOL' ? And why make it inline? It
> surely does not need to be access that often?
Good point. I'll drop inline from the next version, thanks!
Tycho