Re: [PATCH v2] nvme: Fix nvme reset command timeout handling

[Keith Busch]

On Thu, Aug 10, 2017 at 11:23:31AM +0200, Johannes Thumshirn wrote:
> From: Keith Busch <keith.busch@xxxxxxxxx>
> 
> We need to return an error if a timeout occurs on any NVMe command during
> initialization. Without this, the nvme reset work will be stuck. A timeout
> will have a negative error code, meaning we need to stop initializing
> the controller. All postitive returns mean the controller is still usable.
> 
> bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196325
> 
> Signed-off-by: Keith Busch <keith.busch@xxxxxxxxx>
> Cc: Martin Peres <martin.peres@xxxxxxxxx>
> [jth consolidated cleanup path ]
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

This looks great, thanks for fixing that up!

I noticed the HMB setting in pci.c can also potentially timeout. We can
deal with that later.