Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements
From: Vitaly Kuznetsov
Date: Thu Aug 10 2017 - 13:00:25 EST
Ingo Molnar <mingo@xxxxxxxxxx> writes:
> I'm getting this build failure with this series:
>
> arch/x86/hyperv/mmu.c: In function âhyperv_setup_mmu_opsâ:
> arch/x86/hyperv/mmu.c:256:3: error: âpv_mmu_opsâ undeclared (first use in this
> function)
> pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;
> ^
>
> with the attached (rand-)config.
>
> # CONFIG_PARAVIRT is not set
Ouch, this is definitely required for the new feature. Sorry :-(
I think the best way to handle this (and having in mind upcoming PV
spinlocks for Hyper-V) is something like
diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
index c29cd5387a35..50b89ea0e60f 100644
--- a/drivers/hv/Kconfig
+++ b/drivers/hv/Kconfig
@@ -3,6 +3,7 @@ menu "Microsoft Hyper-V guest support"
config HYPERV
tristate "Microsoft Hyper-V client drivers"
depends on X86 && ACPI && PCI && X86_LOCAL_APIC && HYPERVISOR_GUEST
+ select PARAVIRT
help
Select this option to run Linux as a Hyper-V client operating
system.
added to PATCH7 of the series. In case nobody objects, would you like me
to resend the patch or do the whole v11 submission?
Thanks and sorry for the breakage,
--
Vitaly