Re: [PATCH 0/3] selfttests: timers ksft_ stubs handling changes
From: John Stultz
Date: Thu Aug 10 2017 - 20:11:03 EST
On Thu, Aug 10, 2017 at 4:53 PM, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
> This patch series consists of changes to:
>
> Move ksft_ stubs from individual tests into kselftest_stubs.h and change
> tests to include it.
>
> Fix posix_timers and freq-step tests to run without ksft_ framework.
>
> This is in preparation to convert timers tests to ksft TAP 13 format.
>
> Question for John Stultz:
>
> The conversion work will be easier without the requirement to be able to
> build and run these tests without ksft_ framework. So far the stubs are
> simpler. It is might be necessary to ifdef some code paths to have sane
> output for both KTEST and !KTEST cases.
>
> Would it be easier to pull in kselftest.h into timers external repo
> (if one still exists). This is based on the observation that newer
> timer tests don't support !KTEST case e.g: posix_timers and freq-step.
>
> Please review and let me know how you would like me to proceed with the
> conversion. I am looking for answer to how important is it to continue to
> support !KTEST case.
Yea. I'm thinking at this point I'm fine with dropping the attempt to
keep kselftest and my external timekeeping tests in sync.
Though something that might be nice however is having some place that
keeps tarball releases of kselftest around? As it would make pulling
tests onto a target machine a bit easier. Does that already exist?
thanks
-john