Re: [PATCH 1/9] devicetree: bindings: Add sata port phy config parameters in ahci-ceva

[Michal Simek]

On 10.8.2017 21:07, Rob Herring wrote:
> On Fri, Aug 04, 2017 at 03:18:10PM +0200, Michal Simek wrote:
>> From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xxxxxxxxxx>
>>
>> This patch adds device tree bindings for sata port phy parameters
>> in the ahci-ceva.txt file.
>>
>> Signed-off-by: Anurag Kumar Vulisha <anuragku@xxxxxxxxxx>
>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>> ---
>>
>>  .../devicetree/bindings/ata/ahci-ceva.txt          | 39 ++++++++++++++++++++++
>>  1 file changed, 39 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> index 7ca8b976c13a..f97546f61444 100644
>> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> @@ -5,6 +5,36 @@ Required properties:
>>    - compatible: Compatibility string. Must be 'ceva,ahci-1v84'.
>>    - clocks: Input clock specifier. Refer to common clock bindings.
>>    - interrupts: Interrupt specifier. Refer to interrupt binding.
>> +  - ceva,p0-cominit-params: OOB timing value for COMINIT parameter for port 0.
>> +  - ceva,p1-cominit-params: OOB timing value for COMINIT parameter for port 1.
>> +			The fields for the above parameter must be as shown below:
>> +			ceva,phy-cominit-params = /bits/ 8 <CIBGMN CIBGMX CIBGN CINMP>;
> 
> phy? Should be pN?

pN will be in v2.

Thanks,
Michal