Re: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers

[Philipp Zabel]

On Fri, 2017-08-11 at 15:32 +0300, Cihangir Akturk wrote:
> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> and drm_*_unreference() helpers.
> 
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to
> use the new APIs.
> 
> Generated by: scripts/coccinelle/api/drm-get-put.cocci
> 
> Signed-off-by: Cihangir Akturk <cakturk@xxxxxxxxx>
> ---
> Âdrivers/gpu/drm/mediatek/mtk_drm_fb.cÂÂ| 4 ++--
> Âdrivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
> Â2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> b/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> index d4246c9..0d8d506 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_fb.c
> @@ -58,7 +58,7 @@ static void mtk_drm_fb_destroy(struct
> drm_framebuffer *fb)
> Â
> Â	drm_framebuffer_cleanup(fb);
> Â
> -	drm_gem_object_unreference_unlocked(mtk_fb->gem_obj);
> +	drm_gem_object_put_unlocked(mtk_fb->gem_obj);
> Â
> Â	kfree(mtk_fb);
> Â}
> @@ -160,6 +160,6 @@ struct drm_framebuffer
> *mtk_drm_mode_fb_create(struct drm_device *dev,
> Â	return &mtk_fb->base;
> Â
> Âunreference:
> -	drm_gem_object_unreference_unlocked(gem);
> +	drm_gem_object_put_unlocked(gem);
> Â	return ERR_PTR(ret);
> Â}
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index 8ec963f..f595ac8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -122,7 +122,7 @@ int mtk_drm_gem_dumb_create(struct drm_file
> *file_priv, struct drm_device *dev,
> Â		goto err_handle_create;
> Â
> Â	/* drop reference from allocate - handle holds it now. */
> -	drm_gem_object_unreference_unlocked(&mtk_gem->base);
> +	drm_gem_object_put_unlocked(&mtk_gem->base);
> Â
> Â	return 0;
> Â

Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

regards
Philipp