Re: [PATCH V2 2/2] pinctrl: qcom: spmi-gpio: Add dtest route for digital input

[Bjorn Andersson]

On Tue 18 Jul 23:30 PDT 2017, fenglinw@xxxxxxxxxxxxxx wrote:
[..]
> @@ -528,6 +547,20 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
>  	if (ret < 0)
>  		return ret;
>  
> +	if (pad->dtest_buffer == 0) {
> +		val = 0;
> +	} else {
> +		if (pad->lv_mv_type) {
> +			val = pad->dtest_buffer - 1;
> +			val |= PMIC_GPIO_LV_MV_DIG_IN_DTEST_EN;
> +		} else {
> +			val = 1 << (pad->dtest_buffer - 1);

val = BIT(pad->dtest_buffer - 1);


Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn