RE: [linux-devel] [PATCH 3/3] core-arm: add a member about dma_map_ops in dev_archdata struct

From: Leo Li
Date: Fri Aug 11 2017 - 12:38:57 EST




> -----Original Message-----
> From: linux-devel-bounces@xxxxxxxxxxxxxxxxxxxx [mailto:linux-devel-
> bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of yinbo.zhu@xxxxxxx
> Sent: Friday, August 11, 2017 5:01 AM
> To: linux-devel@xxxxxxxxxxxxxxxxxxxx; Yinbo Zhu <yinbo.zhu@xxxxxxx>; Rob
> Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
> Russell King <linux@xxxxxxxxxxxxxxx>; Felipe Balbi <balbi@xxxxxxxxxx>
> Cc: open list <devicetree@xxxxxxxxxxxxxxx>; Laurent Pinchart
> <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>; Catalin Marinas
> <catalin.marinas@xxxxxxx>; open list <linux-usb@xxxxxxxxxxxxxxx>; open list
> <linux-kernel@xxxxxxxxxxxxxxx>; Doug Ledford <dledford@xxxxxxxxxx>;
> Stefano Stabellini <sstabellini@xxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Bart Van Assche
> <bart.vanassche@xxxxxxxxxxx>; moderated list <linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx>
> Subject: [linux-devel] [PATCH 3/3] core-arm: add a member about
> dma_map_ops in dev_archdata struct
>
> From: "yinbo.zhu" <yinbo.zhu@xxxxxxx>

The dma_ops was just moved from struct dev_archdata to struct device with commit 5657933dbb6e25feaf5d8df8c88f96cdade693a3. Don't duplicate the dma_ops in both places if you don't have a good reason.

>
> Signed-off-by: yinbo.zhu <yinbo.zhu@xxxxxxx>
> ---
> arch/arm/include/asm/device.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h
> index 220ba20..c93d3df 100644
> --- a/arch/arm/include/asm/device.h
> +++ b/arch/arm/include/asm/device.h
> @@ -7,6 +7,7 @@
> #define ASMARM_DEVICE_H
>
> struct dev_archdata {
> +const struct dma_map_ops *dma_ops;
> #ifdef CONFIG_DMABOUNCE
> struct dmabounce_device_info *dmabounce; #endif
> --
> 2.1.0.27.g96db324
>
> _______________________________________________
> linux-devel mailing list
> linux-devel@xxxxxxxxxxxxxxxxxxxx
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgforge.
> freescale.net%2Fmailman%2Flistinfo%2Flinux-
> devel&data=01%7C01%7Cleoyang.li%40nxp.com%7Cc83542988dac448bd8b908
> d4e0a230af%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=1pbSjxG781
> yjcCF%2BuXbRCkV6ytbfTTgQkHNWmm0e9nk%3D&reserved=0