Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

From: Greg Kroah-Hartman
Date: Sat Aug 12 2017 - 19:23:13 EST


On Sat, Aug 12, 2017 at 11:56:22PM +0200, Hans de Goede wrote:
> > 'u32' is not an approprioate type for a kernel header, use '__u32'
> > instead.
>
> Huh I thought that u32 was preferred, but I guess that it is not allowed
> in uapi headers due to potential conflicts and it should be __u32 in uapi
> headers ?

The __ version should always be used in structures/variables that cross
the user/kernel boundry as they are guaranteed to be correct that way.
That is a requirement.

Use the "normal" non __ versions for in-kernel only variables.

hope this helps,

greg k-h