Re: [PATCH v1 1/2] hyperv: Include linux/types.h to avoid build break

[Andy Shevchenko]

On Sun, 2017-08-13 at 16:34 +0300, Andy Shevchenko wrote:
> The commit 2ffd9e33ce4a
> 
> ÂÂÂÂ("x86/hyper-v: Use hypercall for remote TLB flush")
> 
> introduced a new C-file where uapi/linux/hyperv.h is included first.
> 
> This makes build failed since UAPI headers are heavily dependent to
> special
> types of variables, e.g. __u8.
> 
> Â CCÂÂÂÂÂÂarch/x86/hyperv/mmu.o
> In file included from include/linux/hyperv.h:28:0,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfrom arch/x86/hyperv/mmu.c:3:
> include/uapi/linux/hyperv.h:71:2: error: unknown type name â__u8â
> Â __u8 operation;
> Â ^~~~
> 
> Include linux/types.h to the UAPI header like many others do.
> 

Oops, it's because I have an update to this file in my local uuid
branch.

In any case this is right thing to do independently of uuid.h inclusion.

Please, ignore this patch for now, but note the second one is still
valid.

> Cc: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> Cc: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> Cc: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Cc: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> Âinclude/uapi/linux/hyperv.h | 2 ++
> Â1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
> index 7560c0aa60e3..aaf32131b556 100644
> --- a/include/uapi/linux/hyperv.h
> +++ b/include/uapi/linux/hyperv.h
> @@ -25,6 +25,8 @@
> Â#ifndef _UAPI_HYPERV_H
> Â#define _UAPI_HYPERV_H
> Â
> +#include <linux/types.h>
> +
> Â/*
> Â * Framework version for util services.
> Â */

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy