Re: [PATCH 1/4] selinux: Delete eight unnecessary variable assignments
From: Serge E. Hallyn
Date: Sun Aug 13 2017 - 12:24:14 EST
Quoting Serge E. Hallyn (serge@xxxxxxxxxx):
> Quoting SF Markus Elfring (elfring@xxxxxxxxxxxxxxxxxxxxx):
> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > Date: Sun, 13 Aug 2017 14:17:48 +0200
> >
> > One local variable was reset to zero at the end of these functions.
> > This value will also be set by a previous call of a function if it was
> > executed successfully. Thus omit an extra assignment there.
> >
> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>
> Acked-by: Serge Hallyn <serge@xxxxxxxxxx>
BTW this does add a burden to the maintainers as it makes the
code a bit more fragile in the face of future changes. So my
ack means it looks ok, but if the maintainers don't want to take
it I absolutely understand.