Re: [PATCH] soc: imx: gpcv2: fix regulator deferred probe
From: Shawn Guo
Date: Mon Aug 14 2017 - 01:36:56 EST
On Sun, Aug 13, 2017 at 10:12:13PM -0700, Stefan Agner wrote:
> Hi Shawn,
>
> On 2017-08-04 20:13, Shawn Guo wrote:
> > On Wed, Aug 02, 2017 at 12:51:29PM -0700, Stefan Agner wrote:
> >> If a regulator requests a deferred probe, the power domain gets
> >> initialized twice. This leads to a list double add (without
> >> list debugging the kernel hangs due to the double add later):
> >>
> >> WARNING: CPU: 0 PID: 19 at lib/list_debug.c:31 __list_add_valid+0xbc/0xc4
> >> list_add double add: new=c1229754, prev=c12383b4, next=c1229754.
> >>
> >> Initialize the power domain after we get the regulator. Also do
> >> not print an error in case the regulator defers probing.
> >>
> >> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> >> Cc: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> >> Cc: linux-kernel@xxxxxxxxxxxxxxx
> >> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> >> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
> >
> > Applied, thanks.
>
> As of 4.13-rc5 this did not make it upstream yet, I guess still on its
> way?
Yes, Stefan. It's on the way to arm-soc [1], but not yet responded.
Shawn
[1] https://www.spinics.net/lists/arm-kernel/msg598634.html