Re: [PATCH] ext4: add missing xattr hash update

[Theodore Ts'o]

On Sun, Aug 06, 2017 at 01:03:19PM -0700, Tahsin Erdogan wrote:
> When updating an extended attribute, if the padded value sizes are the
> same, a shortcut is taken to avoid the bulk of the work. This was fine
> until the xattr hash update was moved inside ext4_xattr_set_entry().
> With that change, the hash update got missed in the shortcut case.
> 
> Thanks to ZhangYi (yizhang089@xxxxxxxxx) for root causing the problem.
> 
> Fixes: daf8328172df ("ext4: eliminate xattr entry e_hash recalculation for removes")
> 
> Reported-by: Miklos Szeredi <miklos@xxxxxxxxxx>
> Signed-off-by: Tahsin Erdogan <tahsin@xxxxxxxxxx>

Thanks, applied.

					- Ted